fix: Truncate NIfTI header data to avoid extensions #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Dec 4, 2024
Comment on lines
94
to
107
| /** | ||
| * Read bytes in a range efficiently from a given file | ||
| * | ||
| * Reads up to size bytes, starting at offset. | ||
| * If EOF is encountered, the resulting array may be smaller. | ||
| */ | ||
| async readBytes(size: number, offset = 0): Promise<Uint8Array> { | ||
| const handle = this.#openHandle() | ||
| const buf = new Uint8Array(size) | ||
| await handle.seek(offset, Deno.SeekMode.Start) | ||
| await handle.read(buf) | ||
| const nbytes = await handle.read(buf) ?? 0 | ||
| handle.close() | ||
| return buf | ||
| return buf.subarray(0, nbytes) | ||
| } |
There was a problem hiding this comment.
@nellh This seems like it was probably the originally intended behavior?
|
Generally needs review. Somewhat urgent for resolving spurious validation failures on OpenNeuro. |
nellh
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple other issues were identified while debugging.
Closes #126.