Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Add full object definitions for valid values in schema #919

Merged
merged 66 commits into from
Jun 27, 2023
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
a479734
Add some descriptions. Mostly just TODOs for now.
tsalo Nov 1, 2021
95309ab
Start rendering value restrictions in descriptions.
tsalo Nov 1, 2021
21f6141
Fix.
tsalo Nov 1, 2021
6f14112
Revert rendering. Will move to separate PR.
tsalo Nov 1, 2021
14a685b
Merge branch 'master' into enum-definitions
tsalo Nov 9, 2021
f29dd8d
Merge branch 'master' into enum-definitions
tsalo Jan 5, 2022
c984dbe
Run black.
tsalo Jan 5, 2022
93c64b3
Merge branch 'master' into enum-definitions
tsalo Jan 31, 2022
bbe5b52
Add more enum descriptions.
tsalo Jan 31, 2022
7a0bcee
Add nonstandard and non-template coordinate systems.
tsalo Jan 31, 2022
4432b20
Fix linting issues.
tsalo Jan 31, 2022
b624642
Merge branch 'master' into enum-definitions
tsalo Feb 1, 2022
6958fe1
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Aug 15, 2022
99234a8
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Aug 19, 2022
a37b32c
Run prettier.
tsalo Aug 19, 2022
5732d70
Make the expanded enums into objects.
tsalo Aug 19, 2022
4c398a2
Fix up rendering, hopefully.
tsalo Aug 19, 2022
ca462ea
Update metadata.yaml
tsalo Aug 19, 2022
0a1f1c0
Update render.py
tsalo Aug 19, 2022
c09aacb
Merge branch 'master' into enum-definitions
tsalo Aug 19, 2022
4250648
whoops.
tsalo Aug 19, 2022
f120c56
Merge branch 'enum-definitions' of https://github.com/tsalo/bids-spec…
tsalo Aug 19, 2022
82ceccc
Update render.py
tsalo Aug 19, 2022
6175095
Whoops!
tsalo Aug 19, 2022
7e6bb88
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Aug 31, 2022
a30dfa2
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Nov 10, 2022
f6f908b
Finish resolving conflicts.
tsalo Nov 10, 2022
0584e80
Move enums to a separate file.
tsalo Nov 10, 2022
f2e06ec
Fix on and off.
tsalo Nov 10, 2022
5ff4974
Remove duplicate keys.
tsalo Nov 10, 2022
9d544b1
Merge branch 'master' into enum-definitions
tsalo Mar 23, 2023
57d4efb
Start adding channel type values.
tsalo Mar 23, 2023
d80695b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 23, 2023
fa741ba
Add EEG columns.
tsalo Mar 23, 2023
695d637
Remove empty entries.
tsalo Mar 23, 2023
787df4d
Merge branch 'enum-definitions' of https://github.com/tsalo/bids-spec…
tsalo Mar 23, 2023
9dd5b1c
Add MEG channels.
tsalo Mar 23, 2023
d58f520
Add NIRS channels.
tsalo Mar 23, 2023
33be615
Try fixing the formatting.
tsalo Mar 23, 2023
b31681a
Fix.
tsalo Mar 23, 2023
5f7f8d6
OTHER sex isn't the same as OTHER channel type.
tsalo Mar 24, 2023
1be0ec6
Consolidate channels enums across datatypes.
tsalo Mar 30, 2023
5194e16
Replace name with value.
tsalo Mar 30, 2023
2cdde61
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Mar 30, 2023
91b39fd
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Apr 27, 2023
e36f12f
Replicate #1478.
tsalo May 4, 2023
6b84688
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo May 4, 2023
984a206
Add .value to value refs.
tsalo May 4, 2023
8a769c1
Add tags to channel values.
tsalo Jun 1, 2023
5d4d9b8
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Jun 1, 2023
d82d45b
ENH: Allow for dereferencing individual values in schema
effigies Jun 1, 2023
ff4bf03
Merge remote-tracking branch 'upstream/master' into enum-definitions
tsalo Jun 6, 2023
189120e
Rename values to enum.
tsalo Jun 6, 2023
15bf452
Rename enum to enum_values.
tsalo Jun 8, 2023
161f612
Fix test.
tsalo Jun 8, 2023
8c642d0
Rename and move enums around.
tsalo Jun 8, 2023
47edbf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
387971d
Update columns.yaml
tsalo Jun 8, 2023
5715e27
Merge branch 'enum-definitions' of https://github.com/tsalo/bids-spec…
tsalo Jun 8, 2023
223e7f4
Merge branch 'master' into enum-definitions
tsalo Jun 8, 2023
082dd30
Document new sub-namespace.
tsalo Jun 8, 2023
e262eeb
Fix table.
tsalo Jun 8, 2023
8ffd745
Remove unused enum groups.
tsalo Jun 15, 2023
5ddeff6
Apply suggestions from code review
tsalo Jun 15, 2023
b0d6d38
Update the other direction enum defs.
tsalo Jun 15, 2023
41189dc
Merge branch 'master' into enum-definitions
sappelhoff Jun 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions src/schema/objects/entities.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,15 @@ mtransfer:
respectively.
type: string
enum:
- "on"
- "off"
- "on":
name: "on"
description: |
The image acquired in the presence of the magnetization transfer pulse,
also known as the off-resonance pulse.
- "off":
name: "off"
description: |
The image acquired in the absence of the magnetization transfer pulse.
part:
name: Part
entity: part
Expand All @@ -178,10 +185,25 @@ part:
omitted.
type: string
enum:
- mag
- phase
- real
- imag
- mag:
name: magnitude
description: |
A magnitude image, typically paired with an associated "phase" image.
- phase:
name: phase
description: |
A phase image, typically paird with an associated "magnitude" (part-mag) image.
Images with this key/value pair MAY be in radians or in arbitrary units.
The sidecar JSON file MUST include the units of the `phase` image.
The possible options are `rad` or `arbitrary`.
- real:
name: real
description: |
A real-valued image, typically paired with an associated "imaginary" (part-imag) image.
- imag:
name: imaginary
description: |
An imaginary-valued image, typically paird with an associated "real" image.
processing:
name: Processed (on device)
entity: proc
Expand Down
Loading