feat(schema): Encode qMRI metadata requirements #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
commented
Dec 19, 2024
| @@ -303,7 +303,7 @@ and a guide for using macros can be found at | |||
| | -------------------- | ---------------------------------------------------------------------------------------------------- | | |||
| | TB1DAM | `FlipAngle` | | |||
| | TB1EPI | `EchoTime`, `FlipAngle`, `TotalReadoutTime`, `MixingTime` | | |||
| | TB1AFI | `RepetitionTime` | | |||
| | TB1AFI | `RepetitionTimeExcitation` | | |||
There was a problem hiding this comment.
@agahkarakuzu I believe this is what TB1AFI should have said, but I want to run it by you.
|
Hi Chris! Yes, this sequence has interleaved TRs, and both of them are of type Should we explicitly mention https://bids-specification.readthedocs.io/en/stable/appendices/qmri.html#tb1afi-specific-notes |
|
I think that's fine. I probably could have read more closely; I was really just looking at the table and the glossary definitions of the different TRs. |
effigies
added
needs review
schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the schema in the maintenance branch, as this does not change the meaning of the specification. This also fixes a minor bug in the specification text, although we don't have a method to rerender it.
Fixes #2018.