Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Allow acq-* to relate physio data to MRI data in anat/ as described in #2164 #1990

Closed
wants to merge 2 commits into from

Conversation

tstoeter
Copy link

The deno based validator did not accept files like sub-01_acq-T1w_physio.tsv.gz located in anat/ and related to the T1w anatomy. This was, because a task was required, which was inherited from rules.files.raw.task.timeseries.entities. The key task is now overridden to optional. Please also see issue #2164 for more information and related patches.

…ed in #2164

The deno based validator did not accept files like `sub-01_acq-T1w_physio.tsv.gz` located in `anat/` and related to the T1w anatomy. This was, because a task was required, which was inherited from `rules.files.raw.task.timeseries.entities`. The key task is now overridden to optional. Please also see issue #2164 for more information and related patches.
@tsalo
Copy link
Member

tsalo commented Nov 22, 2024

I think mod might make more sense for this.

@tstoeter
Copy link
Author

Thank you, @tsalo, for your suggestion, indeed from reading the specs mod seems more appropriate. I have tested it and received another error:

[ERROR] ENTITY_NOT_IN_RULE Entity not listed as required or optional for files with this suffix
		/sub-11/anat/sub-11_mod-T1w_physio.tsv.gz - mod not in rule rules.files.raw.task.timeseries__anat

I believe, this requires another modification of the schema to fix it.

@effigies
Copy link
Collaborator

The task entity is already inherited via

entities:
$ref: rules.files.raw.task.timeseries.entities

@effigies effigies closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants