Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #1967

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[pre-commit.ci] pre-commit autoupdate #1967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397f08c
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Oct 21, 2024
269fd7a
remove import checks for old pythons
Remi-Gau Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ repos:
- id: codespell
args: ["--config=.codespellrc", "--dictionary=-", "--dictionary=.codespell_dict"]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.11.2
rev: v1.12.1
hooks:
- id: mypy
# Sync with project.optional-dependencies.typing
Expand Down
6 changes: 1 addition & 5 deletions tools/schemacode/bidsschematools/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import logging
import tempfile
from importlib.resources import as_file, files
from subprocess import run

try:
from importlib.resources import as_file, files
except ImportError: # PY<3.9
from importlib_resources import as_file, files

Comment on lines -5 to -9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is OK given that we do only support python >= 3.9 now

import pytest

lgr = logging.getLogger()
Expand Down
6 changes: 1 addition & 5 deletions tools/schemacode/bidsschematools/tests/test_make_testdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import os
import shutil

try:
from importlib.resources import files
except ImportError: # PY<3.9
from importlib_resources import files
from importlib.resources import files

import pytest

Expand Down