[MAINT] switch bidsschematools to pyproject.toml #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remi-Gau
added
the
exclude-from-changelog
Remi-Gau
commented
Oct 8, 2024
tools/schemacode/pyproject.toml
Outdated
| dependencies = [ | ||
| "click", | ||
| "pyyaml", | ||
| "importlib_resources; python_version < '3.9'", |
There was a problem hiding this comment.
I guess this can go now, no?
Remi-Gau
commented
Oct 8, 2024
Remi-Gau
commented
Oct 8, 2024
|
I also think it's okay to keep using |
tried and it was a bit easier |
|
This is good to go for me |
effigies
reviewed
Oct 11, 2024
.pre-commit-config.yaml
Outdated
| rev: v2.14.0 | ||
| hooks: | ||
| - id: pretty-format-toml | ||
| args: [--autofix, --indent, '4'] |
There was a problem hiding this comment.
I don't think sorting leads to a very readable pyproject.toml, where I think there are some rough importance levels that are good to indicate (e.g. "name" should be the first thing in project metadata).
Suggested change
| args: [--autofix, --indent, '4'] | |
| args: [--autofix, --indent, '4', --no-sort] |
There was a problem hiding this comment.
good with me
defo not a hill I want to die on
There was a problem hiding this comment.
forgot to commit this one
tools/schemacode/pyproject.toml
Outdated
Comment on lines
101
to
115
| [tool.setuptools.dynamic] | ||
| version = {file = "bidsschematools/data/schema/SCHEMA_VERSION"} | ||
|
|
||
| [tool.setuptools.package-data] | ||
| bidsschematools = [ | ||
| "data/metaschema.json", | ||
| "data/schema/BIDS_VERSION", | ||
| "data/schema/SCHEMA_VERSIO", | ||
| "data/schema/**/*.yaml", | ||
| "tests/data/**/*", | ||
| "tests/data/**/.bidsignore" | ||
| ] | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["bidsschematools*"] |
There was a problem hiding this comment.
IMO packager config should come immediately after the [project] tables.
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
added
the
schema-code
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
Oct 28, 2024
…ttype * commit 'v1.10.0-35-g5f7004819': (218 commits) Include entity-less "scans.json" into an example of inheritance principle (bids-standard#1945) fix(checks): Enforce timing mutual exclusions on BOLD/ASL data only (bids-standard#1969) refactor contributing (bids-standard#1965) [pre-commit.ci] pre-commit autoupdate (bids-standard#1967) [SCHEMA] Allow physio files for anat datatype (bids-standard#1961) [pre-commit.ci] pre-commit autoupdate Add an empty line in hope to get table rendered properly in "Ordering rules" section (bids-standard#1953) schema: add check for duplicate READMEs (bids-standard#1952) [MAINT] switch bidsschematools to pyproject.toml (bids-standard#1948) fix(schema): Disable TaskName check for channels and markers files Permit and warn on task/acquisition/run for electrodes and coordsystems [FIX] Allow (but discourage) task entity for coordsystem.json fix(schema): Limit MRI metadata checks to NIfTIs fix: Only check for sorted times in arrays py3.13 (bids-standard#1947) [pre-commit.ci] pre-commit autoupdate (bids-standard#1946) [FIX] Update changelog links to avoid redirects (bids-standard#1944) [ENH] Update DWI suffixes to include most common scanner derivatives (bids-standard#1864) [pre-commit.ci] pre-commit autoupdate [MAINT] Update Release_Protocol.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pyproject.toml for config and package metadata.