Include entity-less "scans.json" into an example of inheritance principle #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
requested review from
effigies and
Lestropie
and removed request for
DimitriPapadopoulos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
- Coverage 87.23% 86.87% -0.36%
==========================================
Files 16 16
Lines 1410 1410
==========================================
- Hits 1230 1225 -5
- Misses 180 185 +5 ☔ View full report in Codecov by Sentry. |
|
I guess I misunderstood the previous discussion. I thought we did not need to single out This seems fine, though. |
|
it is just an example to make it clearer - nothing is singled out IMHO. |
please bless it then with an approval ;-) |
effigies
approved these changes
Oct 17, 2024
Remi-Gau
approved these changes
Oct 17, 2024
Remi-Gau
reviewed
Oct 17, 2024
|
added some semantic linebreak |
effigies
added
the
exclude-from-changelog
|
Added the Please let me know if you disagree. |
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
Oct 28, 2024
…ttype * commit 'v1.10.0-35-g5f7004819': (218 commits) Include entity-less "scans.json" into an example of inheritance principle (bids-standard#1945) fix(checks): Enforce timing mutual exclusions on BOLD/ASL data only (bids-standard#1969) refactor contributing (bids-standard#1965) [pre-commit.ci] pre-commit autoupdate (bids-standard#1967) [SCHEMA] Allow physio files for anat datatype (bids-standard#1961) [pre-commit.ci] pre-commit autoupdate Add an empty line in hope to get table rendered properly in "Ordering rules" section (bids-standard#1953) schema: add check for duplicate READMEs (bids-standard#1952) [MAINT] switch bidsschematools to pyproject.toml (bids-standard#1948) fix(schema): Disable TaskName check for channels and markers files Permit and warn on task/acquisition/run for electrodes and coordsystems [FIX] Allow (but discourage) task entity for coordsystem.json fix(schema): Limit MRI metadata checks to NIfTIs fix: Only check for sorted times in arrays py3.13 (bids-standard#1947) [pre-commit.ci] pre-commit autoupdate (bids-standard#1946) [FIX] Update changelog links to avoid redirects (bids-standard#1944) [ENH] Update DWI suffixes to include most common scanner derivatives (bids-standard#1864) [pre-commit.ci] pre-commit autoupdate [MAINT] Update Release_Protocol.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scan.json#789