[FIX] Move description of "n/a" above "String values" to avoid any association #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
approved these changes
Oct 3, 2024
- It somewhat addresses concern/discussion in bids-standard#1938
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1940 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1225 1225
Misses 185 185 ☔ View full report in Codecov by Sentry. |
|
@bids-maintenance - this is an easy low hanging fruit PR. |
yarikoptic
added
schema
|
No semantic change. I'm going to go ahead and merge and let people yell at me if they feel very strongly about the second review. |
effigies
added
the
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as they should be applicable also to numeric values.