Strip possibly present trailing / (os.sep) before adding one #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without that users must have trailing / removed, but nobody checks for that etc. So now we have "raw//" etc, e.g. at https://bids-specification.readthedocs.io/en/latest/derivatives/common-data-types.html#example-use-of-a-descriptionstsv-file With this change it would make it easier on user and guaranteed to render consistently correctly
effigies
added
the
exclude-from-changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1230 1230
Misses 180 180 ☔ View full report in Codecov by Sentry. |
|
ping @bids-standard/maintainers on this trivial PR |
Remi-Gau
approved these changes
Sep 10, 2024
rwblair
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that users must have trailing / removed, but nobody checks for that etc. So now we have "raw//" etc, e.g. at
https://bids-specification.readthedocs.io/en/latest/derivatives/common-data-types.html#example-use-of-a-descriptionstsv-file
With this change it would make it easier on user and guaranteed to render consistently correctly
os.septhere in the code making rendering dependent on OS on which it is rendered. I will add commit to change toposixpath.sep.