Revert "[ENH] Specify the naming of scanner-generated TRACE and ADC volumes" #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumes (…" This reverts commit 1d929e5.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1919 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1230 1230
Misses 180 180 ☔ View full report in Codecov by Sentry. |
effigies
added
the
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1725 because there is an intent to replace it with #1864.
If #1864 is not accepted in time for 1.10.0, then this will be merged so that it can come in a later release without backwards compatibility issues.