Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): Authors is recommended if CITATION.cff is absent #1916

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Aug 29, 2024

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (7f1f673) to head (eab2a67).
Report is 115 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1916   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1230     1230           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies changed the title feat(schema): Add CITATION.cff contents to context, skip NO_AUTHORS warning fix(schema): Authors is recommended if CITATION.cff is absent Aug 29, 2024
@effigies
Copy link
Collaborator Author

Before

image

After

image

@effigies effigies merged commit 9ede0c5 into bids-standard:master Sep 5, 2024
27 checks passed
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Sep 5, 2024
@effigies effigies deleted the enh/citation.cff branch September 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants