Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STY] Use wikipedia links, separate URL definitions #1911

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

effigies
Copy link
Collaborator

Should fix checklinks. We also don't need to be pointing to an ad-supported skin for wikipedia.

I moved the URL definitions out of the table so that URLs can be edited without modifying the width of the table in the future.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 27, 2024
@effigies effigies added this to the 1.10.0 milestone Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (d6803bf) to head (c83f8ec).
Report is 132 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1911   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1230     1230           
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies requested a review from Remi-Gau August 27, 2024 14:23
@Remi-Gau
Copy link
Collaborator

I don't think anyone would be outraged if this was merged without a second review.

@effigies effigies merged commit 6badf41 into bids-standard:master Aug 28, 2024
27 checks passed
@effigies effigies deleted the sty/wikilinks branch August 28, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants