feat(schema): Move coordsystem.json rules out of rules.sidecars #1892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mixing up JSON and sidecar rules, but conceptually, sidecar metadata belongs to the data file, not the JSON file itself.
coordsystem.json
is its own JSON file, and needs to be validated as its own thing, in the same waydataset_description.json
is.The upshot is that selectors should use
json.<whatever>
instead ofsidecar.<whatever>
to make conditional requirements, and it will be easiest to keep these entirely separate in the schema.