Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Declare context definition to be JSON schema, fix validation errors #1867

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Jul 10, 2024

meta.context.contextmeta.context is a JSON schema document embedded in the BIDS schema. This establishes that in metaschema.json and resolves the bugs that would have been discovered sooner if we had done this.

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (8367dbe) to head (8f83656).
Report is 282 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files          16       16           
  Lines        1380     1380           
=======================================
  Hits         1215     1215           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

@rwblair I think this should be a quick one.

@effigies
Copy link
Collaborator Author

One question: Do we want to consider removing the extra context: level, and just start with type: object? That would modify the schema structure, but not a lot depends on this yet, so it's probably not a terrible time to do it.

@rwblair
Copy link
Member

rwblair commented Jul 10, 2024

Sounds good to me.

@effigies effigies force-pushed the fix/context-metaschema branch from f988041 to 8f83656 Compare July 10, 2024 23:10
@effigies effigies merged commit 9f2a7a8 into bids-standard:master Jul 11, 2024
27 checks passed
@effigies effigies deleted the fix/context-metaschema branch July 11, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants