-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update DWI suffixes to include most common scanner derivatives #1864
Merged
effigies
merged 20 commits into
bids-standard:master
from
Lestropie:dwi_scanner_derivatives
Oct 2, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e5d9e04
add FA
CPernet 691e73d
FA suffix
CPernet 45c14fd
add FA
CPernet 2e4627e
Update src/schema/rules/files/raw/dwi.yaml
CPernet 4040942
Update src/modality-specific-files/magnetic-resonance-imaging-data.md
CPernet 0b3a498
add colFA
CPernet f28e539
add colFA
CPernet 74220cf
colFA description
CPernet 12b780e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 081a59f
fix(schema): Rename raw reference in derivative rules
effigies b78b033
Update src/modality-specific-files/magnetic-resonance-imaging-data.md
CPernet 583acd1
Update src/modality-specific-files/magnetic-resonance-imaging-data.md
CPernet 5cabca0
Update src/schema/objects/suffixes.yaml
CPernet 04a96f5
Changes to scanner-generated DWI derivatives
Lestropie 0437762
Update src/schema/objects/suffixes.yaml
effigies 65d12ec
Merge branch 'master' into dwi_scanner_derivatives
effigies a4d10f1
MRI: DWI scanner derivatives: Adopt "S0map" suffix
Lestropie bee4b16
Merge branch 'master' into dwi_scanner_derivatives
effigies 97d6a94
Update src/schema/objects/suffixes.yaml
effigies 26ccad7
Merge branch 'master' into dwi_scanner_derivatives
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Projected -> Predicted? Estimated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't feel particularly strongly for any choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bikeshed can be repainted without backwards compatibility issues. If everybody's happy with the suffixes, then let's move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'm fine if others feel like "projected" is the right.