-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crude BIDS compliant sticker design #1824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
+ Coverage 87.92% 88.04% +0.11%
==========================================
Files 16 16
Lines 1375 1380 +5
==========================================
+ Hits 1209 1215 +6
+ Misses 166 165 -1 ☔ View full report in Codecov by Sentry. |
Added a link to the image because I don't read svg. |
Can we for for green rather than red as we are saying that it is a valid thing and not an error. |
sure -- it is green now! |
Sorry, this is literal bikeshedding, but can that green be more like #008000, so slightly darker? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For OHBM 2024 we (bids-standard/steering and some bids-standard/maintainers representative(s) ) are thinking to prepare/print some stickers to "award" (stick to upon author's permission).
I think the idea is very nice, and given the time pressure, this quick-solution should be good enough! (We are big fans of the 80-20 principle here at BIDS, after all 😉 )
Would be good to have a smaller version as well with no text: just the BIDS logo with the green tick mark |
We've got regular stickers: |
@effigies where do those stickers "live" so I could add this one nearby? |
I got these directly from Franklin, so they're just in my email. Happy to put them somewhere I'm told to. |
should we collect them near the logo as I did here or some subfolder there in, or may be better start some https://github.com/bids-standard/artwork ? |
I am a bit inclined to move artwork into its own repository instead of making this one larger and larger. |
May i suggest renaming this repo we already have and repurposing it? |
pushed a small version of it with no text will rename the repo I mentioned and will let @yarikoptic transfer his PR |
OK repo renamed, reorganized and default branch renamed to main. https://github.com/bids-standard/artworks @yarikoptic : your move! |
oh, that is cute! FWIW I did not have time to deliberate on this more and coupled with absence of artistic inclination I just already ordered . Preview was
THANK YOU! Let's move then... will move as a PR there |
For OHBM 2024 we (@bids-standard/steering and some @bids-standard/maintainers representative(s) ) are thinking to prepare/print some stickers to "award" (stick to upon author's permission). Here is my initial crude design attempt. The cut out to be the offset around the text/checkmark. May be make background shiny silver.
WDYT? other ideas/desires? (we would need to act soonish to print in time)
where to actually commit such a thing? should we generate
stickers/
folder somewhere?