Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #1793

Merged
merged 1 commit into from
Apr 18, 2024
Merged

code cleanup #1793

merged 1 commit into from
Apr 18, 2024

Conversation

bendichter
Copy link
Contributor

  • rmv "infra": ":metro:" as it is a repeat
  • fix broken docstrings
  • shield mutable default args

None of these changes should affect the actual performance of the library

* rmv "infra": ":metro:" as it is a repeat
* fix broken docstrings
* shield mutable default args
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.79%. Comparing base (bff4f0c) to head (257b341).

Files Patch % Lines
tools/schemacode/bidsschematools/validator.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
- Coverage   87.88%   87.79%   -0.10%     
==========================================
  Files          16       16              
  Lines        1354     1360       +6     
==========================================
+ Hits         1190     1194       +4     
- Misses        164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies added the schema-code Updates or changes to the code used to parse, filter, and render the schema. label Apr 18, 2024
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Apr 18, 2024
@effigies effigies merged commit d7b3793 into bids-standard:master Apr 18, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants