Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make namespace.to_dict() recurse fully #1790

Merged
merged 3 commits into from
Apr 17, 2024
Merged

FIX: Make namespace.to_dict() recurse fully #1790

merged 3 commits into from
Apr 17, 2024

Conversation

bendichter
Copy link
Contributor

fix #1789

@bendichter bendichter mentioned this pull request Apr 17, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (37b11ec) to head (be24b66).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1790      +/-   ##
==========================================
- Coverage   87.93%   87.88%   -0.05%     
==========================================
  Files          16       16              
  Lines        1351     1354       +3     
==========================================
+ Hits         1188     1190       +2     
- Misses        163      164       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remi-Gau
Remi-Gau reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could add a test to avoid regressions?

effigies
effigies approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@effigies effigies added exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema. labels Apr 17, 2024
@effigies effigies changed the title fix namespace.to_dict FIX: Make namespace.to_dict() recurse fully Apr 17, 2024
@bendichter
Copy link
Contributor Author

Great! I don't have merge privileges

@effigies effigies merged commit bff4f0c into bids-standard:master Apr 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Remi-Gau Remi-Gau Remi-Gau approved these changes

@effigies effigies effigies approved these changes

@tsalo tsalo Awaiting requested review from tsalo

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Namespace.to_dict() does not completely work
3 participants
@bendichter @effigies @Remi-Gau