Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] split physio metadata tables #1746

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Remi-Gau
Copy link
Collaborator

Closes #1745

Just for consistency with other datatypes.

@Remi-Gau Remi-Gau mentioned this pull request Mar 23, 2024
9 tasks
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (bd08602) to head (f896f5d).
Report is 314 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1746   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review March 27, 2024 21:19
@Remi-Gau Remi-Gau requested review from effigies and oesteban March 27, 2024 21:19
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Remi-Gau
Copy link
Collaborator Author

to merge in 5 days...

@Remi-Gau Remi-Gau merged commit dbcb237 into bids-standard:master Apr 2, 2024
27 checks passed
@Remi-Gau Remi-Gau deleted the fix/1745 branch April 2, 2024 09:47
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split physio metadata into a separate tables
5 participants