FIX: Improve detection of admonition end, fixing unrendered links in PDF

[Remi-Gau]

• fixes Some links do not rendered in the PDF #1712

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (28eb790) to head (feb5357).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1738   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Remi-Gau]

OK seems fixed

will clean up

[Remi-Gau]

things look good now

[effigies]

Is that a normal amount of white space? Is it worth collapsing more than two newlines down to two?

[Remi-Gau]

Is that a normal amount of white space? Is it worth collapsing more than two newlines down to two?

Do you mean below the white space below the Genetic Descriptor heading?

[effigies]

Yes.

[Remi-Gau]

pretty sure it has nothing to do with this PR:

see the PDF of our latest release

https://github.com/bids-standard/bids-specification-pdf-releases/blob/main/bids-spec.pdf

[Remi-Gau]

if you say that we should make that gap a tad smaller in another PR, then you have my sword and my bow and my axe.

[effigies]

No worries. Just noticing that your test had some extra newlines and making sure that they aren't causing visual artifacts.