Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add admonitions to task and beh pages #1735

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Mar 21, 2024


  • add some admonitions to task and behavioral pages
  • implement semantic line break in a few places
  • change some wording / capitalization (e.g should --> SHOULD)

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Mar 21, 2024
Comment on lines +20 to +22
one MAY also include data from experiments
performed with no neural recordings.
The results of those experiments MAY be stored in the `beh` directory
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to using MAY here

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Mar 21, 2024

when playing around with this I realized that macros should not be put into admonitions other wise the output won't be what you expect.

Will mention in the contributing doc.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (943c20e) to head (62c71d3).
Report is 16 commits behind head on master.

❗ Current head 62c71d3 differs from pull request most recent head 440cbf0. Consider uploading reports for the commit 440cbf0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1735   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau added the formatting Aesthetics and formatting of the spec label Apr 16, 2024
@bendhouseart bendhouseart self-assigned this Jul 11, 2024
@bendhouseart bendhouseart self-requested a review July 11, 2024 17:40
@bendhouseart bendhouseart removed their assignment Jul 11, 2024
@effigies effigies merged commit 4397361 into bids-standard:master Jul 25, 2024
23 of 24 checks passed
@Remi-Gau Remi-Gau deleted the enh/admonitions branch July 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec needs review
Projects
Development

Successfully merging this pull request may close these issues.

4 participants