[SCHEMA] Very minor tune ups to the test_rule_objects test while trying to grasp its function #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the point is to go through values, just go through .values() without iterating through keys() and then dereferencing via [key]
Since then also it is not clear if that is indeed some ValueError from within code. I also added a string which summarizes the problem.
yarikoptic
commented
Mar 15, 2024
| schema_obj["objects"][object_type][k]["value"] | ||
| for k in schema_obj["objects"][object_type].keys() | ||
| value["value"] | ||
| for value in schema_obj["objects"][object_type].values() |
There was a problem hiding this comment.
simpler == easier to read and understand
yarikoptic
commented
Mar 15, 2024
effigies
approved these changes
Mar 15, 2024
yarikoptic
commented
Mar 16, 2024
| @@ -100,7 +100,7 @@ def test_rule_objects(schema_obj): | |||
|
|
|||
| if not_found: | |||
| not_found_string = "\n".join([f"{'.'.join(path)} == {val}" for path, val in not_found]) | |||
| raise AssertionError(f"Undefined objects found in rules: {not_found_string}" | |||
| raise AssertionError(f"Undefined objects found in rules: {not_found_string}") | |||
There was a problem hiding this comment.
I could have sworn I have tested it -- must be some hand tremble removed it last moment ;)
TheChymera
approved these changes
Mar 20, 2024
effigies
added
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.