Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Remove stale test comment -- test no longer fails! #1727

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

yarikoptic
Copy link
Collaborator

Test was written by @TheChymera awhile back. I didn't check if it was failing at that point but it is all nice and green now:

❯ python -m pytest -s -v bidsschematools/data/tests/test_rules.py::test_rule_objects
======================================== test session starts ========================================
platform linux -- Python 3.11.8, pytest-8.1.1, pluggy-1.4.0 -- /home/yoh/proj/bids/bids-specification/tools/schemacode/venvs/dev3/bin/python
cachedir: .pytest_cache
rootdir: /home/yoh/proj/bids/bids-specification/tools/schemacode
configfile: pyproject.toml
plugins: cov-4.1.0
collected 1 item                                                                                    

bidsschematools/data/tests/test_rules.py::test_rule_objects PASSED

on master (does fail on #1705)

@yarikoptic yarikoptic requested review from TheChymera and tsalo March 15, 2024 23:09
@yarikoptic yarikoptic requested a review from erdalkaraca as a code owner March 15, 2024 23:09
@effigies effigies added schema-code Updates or changes to the code used to parse, filter, and render the schema. exclude-from-changelog This item will not feature in the automatically generated changelog labels Mar 20, 2024
@effigies effigies merged commit 6d13c80 into bids-standard:master Mar 20, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants