Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-038: Atlases #1714

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

BEP-038: Atlases #1714

wants to merge 19 commits into from

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Feb 28, 2024

This PR proposes the inclusion of BEP-038 into the BIDS specification.

The BEP is hosted on its own branch in the main repository, and BEP leads have been given write permissions to the branch. If you are a BEP lead and having issues writing to the branch, please let a maintainer know and we can make sure you have access.

At present this is a starting point, and I anticipate significant rewriting and reorganization before final merge. There is extensive discussion in #1281 that needs to be turned into concrete proposals. I would suggest keeping the discussion on this PR minimal so that newcomers can follow the thread. When opening PRs against this branch, please include a reference to this PR (#1714) so that it shows up in the thread.

Rendered draft

https://bids-specification--1714.org.readthedocs.build/en/1714/atlas.html

Related discussions

melanieganz and others added 17 commits January 23, 2024 09:23
I made a first draft of the atlas BEP based on the Google doc
Added atlas content
All the content of the BEP038 Google document has been ported to the atlas.md file. Additionally atlas and a definition of what of means was added as an entity. There are still smaller things to fix as some links, references and the tables still need to be inserted.
Fixed details such as linking to entities and suffixes as well as clarified some of the example text.  The tables need still to be fixed.
[BEP038] Style and similar cleanups
@CPernet
Copy link
Collaborator

CPernet commented Mar 31, 2024

@erdalkaraca @tsalo this has passed the review period now, can this be checked and merged? thx

@oesteban
Copy link
Collaborator

oesteban commented Apr 1, 2024

I'm working on a review. Please hold on.

@effigies
Copy link
Collaborator Author

effigies commented Apr 1, 2024

I also have not finished my review/proposed changes. I am unlikely to get to it before the meeting next week as I am traveling for another meeting this week.

@effigies
Copy link
Collaborator Author

effigies commented Apr 4, 2024

This BEP currently needs:

  1. Schema implementation of required checks and filename rules
  2. Examples implementing all significant (ideally all) features proposed to https://github.com/bids-standard/bids-examples
  3. Implementation of all rules in https://github.com/bids-standard/bids-validator and tested on the examples.
  4. A two week public review period announced on all communication channels.

I'm converting this to draft to reflect this status. I'm going to temporarily restrict comments, pending synchronous discussion.

@effigies effigies marked this pull request as draft April 4, 2024 19:53
@bids-standard bids-standard locked as too heated and limited conversation to collaborators Apr 4, 2024
@christinerogers christinerogers marked this pull request as ready for review April 5, 2024 17:02
@sappelhoff sappelhoff marked this pull request as draft April 5, 2024 17:12
@francopestilli
Copy link
Collaborator

Hi, Folks,

Thanks for helping with this BEP. It was great to see several of you at OHB<

I would like to kindly ask to go back to this BEP and make a decision before OHBM. We have a few proposals to pick from (see here), most of them would be fine with @PeerHerholz and myself.

What are the pending issues that would need to be resolved?

@effigies @CPernet @oesteban @PeerHerholz @melanieganz @sappelhoff @christinerogers @tsalo @erdalkaraca @jdkent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants