-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] microelectrode electrophysiology specification (BEP032) #1705
base: master
Are you sure you want to change the base?
Changes from 4 commits
7ec5d5e
2f393ca
648781a
d3c9996
08c92cd
e2030ac
53f1087
fa648fe
eef67df
27547f9
a6ae5e2
9a20e4b
7609276
9be41f9
983975a
1afdc40
6b39d64
f08b163
73012b3
a46e439
05e9611
7ddeb75
2b9e757
6b11f54
1abebea
2a3757d
3f4e941
0853f8a
800ba58
46c91b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,6 +42,38 @@ | |
for privacy purposes. | ||
type: number | ||
unit: year | ||
alpha_rotation: | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
name: alpha_rotation | ||
display_name: Alpha rotation | ||
description: | | ||
Euler angle to match probe extension dimensions (width, height, depth) to global x, y, z coordinates. | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
unit: | ||
degree | ||
associated_brain_region: | ||
name: associated_brain_region | ||
display_name: Associated brain region | ||
description: | | ||
A textual indication on the location of the probe, preferably species-independent terms as obtained e.g. from Uberon. | ||
type: string | ||
associated_brain_region_id: | ||
name: associated_uberon_brain_region_id | ||
display_name: Associated brain region identifier | ||
description: | | ||
An identifier of the associated brain region based on the Uberon ontology for anatomical structures in animals. E.g. “UBERON:0010415” | ||
type: number | ||
associated_brain_region_quality_type: | ||
name: associated_brain_region_quality_type | ||
display_name: Associated brain region quality type | ||
description: | | ||
The method used to identify the associated brain region (estimated|proof) depending on anatomical pictures proofing the location or indirect estimation of the location. | ||
type: string | ||
beta_rotation: | ||
name: beta_rotation | ||
display_name: Beta rotation | ||
description: | | ||
Euler angle to match probe extension dimensions (width, height, depth) to global x, y, z coordinates. | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
unit: | ||
degree | ||
cardiac: | ||
name: cardiac | ||
display_name: Cardiac measurement | ||
|
@@ -84,6 +116,19 @@ | |
- $ref: objects.enums.quat_z.value | ||
- $ref: objects.enums.quat_w.value | ||
- n/a | ||
contact_count: | ||
name: contact_count | ||
display_name: Contact count | ||
description: | | ||
Number of miscellaneous analog contacts for auxiliary signals. | ||
type: number | ||
depth__probes: | ||
name: height | ||
display_name: Height | ||
description: | | ||
Physical height of the probe. | ||
type: number | ||
unit: mm | ||
detector__channels: | ||
name: detector | ||
display_name: Detector Name | ||
|
@@ -116,6 +161,12 @@ | |
description: | | ||
Brief free-text description of the channel, or other information of interest. | ||
type: string | ||
device_serial_number: | ||
name: device_serial_number | ||
display_name: Device serial number | ||
description: | | ||
The serial number of the probe (provided by the manufacturer). | ||
type: string | ||
description__optode: | ||
name: description | ||
display_name: Description | ||
|
@@ -151,6 +202,13 @@ | |
Relative paths to files. | ||
type: string | ||
format: participant_relative | ||
gamma_rotation: | ||
name: gamma_rotation | ||
display_name: Gamma rotation | ||
description: | | ||
Euler angle to match probe extension dimensions (width, height, depth) to global x, y, z coordinates. | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
unit: | ||
degree | ||
group__channel: | ||
name: group | ||
display_name: Channel group | ||
|
@@ -192,6 +250,13 @@ | |
- AMBIDEXTROUS | ||
- Ambidextrous | ||
- n/a | ||
height__probes: | ||
name: height | ||
display_name: Height | ||
description: | | ||
Physical height of the probe. | ||
type: number | ||
unit: mm | ||
hemisphere: | ||
name: hemisphere | ||
display_name: Electrode hemisphere | ||
|
@@ -267,6 +332,12 @@ | |
description: | | ||
Material of the electrode (for example, `Tin`, `Ag/AgCl`, `Gold`). | ||
type: string | ||
material__probes: | ||
name: material__probes | ||
display_name: Material | ||
description: | | ||
A textual description of the base material of the probe. | ||
type: string | ||
metabolite_parent_fraction: | ||
name: metabolite_parent_fraction | ||
display_name: Metabolite parent fraction | ||
|
@@ -391,6 +462,12 @@ | |
- type: string | ||
enum: | ||
- n/a | ||
reference_atlas: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The “reference atlas” if you visually verify the area is basically the atlas you looked at before you nod and said “eh, good enough”. This seems at once an overly detailed (does this really matter? the coordinates are commonly given with sub-mm precision) and underdetermined (what coordinates did you look at in the atlas?). I think it's best just to drop this. |
||
name: reference_atlas | ||
display_name: Reference atlas | ||
description: | | ||
Name of reference atlas used for associated brain region identification, preferrably an ebrains supported atlas. | ||
Check failure on line 469 in src/schema/objects/columns.yaml GitHub Actions / codespell
|
||
type: string | ||
reference_frame: | ||
name: reference_frame | ||
display_name: Reference frame | ||
|
@@ -703,6 +780,12 @@ | |
- $ref: objects.enums.source.value | ||
- $ref: objects.enums.detector.value | ||
- n/a | ||
type__probes: | ||
name: type | ||
display_name: Type | ||
description: | | ||
The type of the probe. | ||
type: string | ||
units: | ||
name: units | ||
display_name: Units | ||
|
@@ -785,6 +868,13 @@ | |
Radioactivity in whole blood samples, | ||
in unit of radioactivity measurements in whole blood samples (for example, `kBq/mL`). | ||
type: number | ||
width__probes: | ||
name: width | ||
display_name: Width | ||
description: | | ||
Physical width of the probe. | ||
type: number | ||
unit: mm | ||
x: | ||
name: x | ||
display_name: X position | ||
|
@@ -870,3 +960,13 @@ | |
- type: string | ||
enum: | ||
- n/a | ||
template_z: | ||
name: template_z | ||
display_name: Z template position | ||
description: | | ||
Assumed or ideal position along the z axis. | ||
anyOf: | ||
- type: number | ||
- type: string | ||
enum: | ||
- n/a |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -331,12 +331,12 @@ split: | |
display_name: Split | ||
description: | | ||
In the case of long data recordings that exceed a file size of 2Gb, | ||
`.fif` files are conventionally split into multiple parts. | ||
Each of these files has an internal pointer to the next file. | ||
`.fif`, `.nwb`, `.nix` files are conventionally split into multiple parts. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NWB files that exceed 2GB are not "conventionally" split into multiple parts. I don't know if this is true for NIX but I doubt it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should look into https://bids-specification.readthedocs.io/en/stable/appendices/entities.html#split may be it would apply |
||
Each of the `.fif` files has an internal pointer to the next file. | ||
This is important when renaming these split recordings to the BIDS convention. | ||
|
||
Instead of a simple renaming, files should be read in and saved under their | ||
new names with dedicated tools like [MNE-Python](https://mne.tools/), | ||
new names with dedicated tools like [MNE-Python](https://mne.tools/) for `.fif`, | ||
which will ensure that not only the filenames, but also the internal file pointers, will be updated. | ||
|
||
It is RECOMMENDED that `.fif` files with multiple parts use the `split-<index>` entity to indicate each part. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
ephys: | ||
suffixes: | ||
- ephys | ||
extensions: | ||
- .nwb | ||
# possible future: serialization in .zarr format to accompany .ome.zarr | ||
# - .nwb.zarr | ||
- .nix | ||
datatypes: | ||
- ephys | ||
entities: | ||
subject: required | ||
session: optional | ||
sample: optional | ||
task: optional | ||
acquisition: optional | ||
run: optional | ||
split: optional | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really recommend renaming the rotation axes to yaw, roll, and pitch (that would be the analogous angle order). There was no consensus either way on the google docs discussion. Someone said both are confusing, which I guess might be expected, but alpha, beta, gamma, are just more confusing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- very adhoc. Let's discuss in google doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAAA4fkI4eY
Could you chime in? I think the other guy commenting might be amenable to accepting this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that both are confusing, but at least alpha, beta and gamma are SO confusing that everyone realizes that additional specification is needed to define them properly. With roll, yaw and pitch it seems at first that all is clear, until you have a number of different people go through different use cases. See the more challenging examples that I posted on the google doc under https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAAA4fkI4eY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertoostenveld sorry, I only now saw the update, reply there. I don't think confusion on purpose is good in this case, because the documentation is very eclectic so we might be sending people down rabbit holes. Wiki, where people will invariably go first, does a particularly poor job explaining both euler and TB angles for the casual non-mathematics-versed user. The only thing that wiki has going for it here are the aircraft animations on the TB page. Yaw, Pitch, Roll, will be intuited correctly as long as we specify the starting postion. That we can do (1) as (I think, it's pretty vague) is currently proposed, aligning the implant with the world coordinate system (meaning most implants will be at yaw 0 pitch -90 roll 0) or (2) relative to the implantation stereotax normal (meaning most implants will be at 0 0 0).
For comparison, Euler commonly has the normal pointing up so most implants will be.... 0 -180 0 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the last BEP032 meeting we discussed further and wanted to follow this approach now (based on the Allen Inst. standard and IBL standard):
Assumption: x,y,z is posterior, ventral, right (unit needs to be specified).
Translational origin (0,0,0) needs to be defined (typically Bregma for rodents).
Rotational origin (0,0,0) is the probe facing up with the tip facing forward. Rotations are all clockwise in degrees and around the tip. For multi-shank probes, the “tip” of the probe is defined as the end of the left shank if you are looking at the electrodes.
The depth (unit needs to be specified) is a translation in the direction that the tip is pointing.
We need to add a “probe_model”, which references probeinterface_library
NOTE: We need to change the electrode x,y,z.
X,y,z in BIDS refers to location in brain, not on probe.