-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] microelectrode electrophysiology specification (BEP032) #1705
Open
yarikoptic
wants to merge
30
commits into
master
Choose a base branch
from
bep032
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7ec5d5e
Add first BEP032 objects
JuliaSprenger 2f393ca
Add ephys modality, start adding _channels but ran into a question on…
yarikoptic 648781a
Add _acq- to ephys, add _channels and _coords
yarikoptic d3c9996
Draft for probes TSV file
TheChymera 08c92cd
Fix preferably typo
yarikoptic e2030ac
Comment out not yet defined iephys and add ephys to datatypes where i…
TheChymera 53f1087
Added probes file
TheChymera fa648fe
Describe modality/datatype as "Microelectrode Electrophysiology"
yarikoptic eef67df
Remove iephys entirely since I think it was just inspired by DANDI la…
yarikoptic 27547f9
Initial content for ephys document and initial filename template tree
yarikoptic a6ae5e2
Merge remote-tracking branch 'upstream/master' into bep032
Remi-Gau 9a20e4b
pacify pre-commit
Remi-Gau 7609276
add to TOC
Remi-Gau 9be41f9
semantic line break and fix
Remi-Gau 983975a
Addressed minor left over lint complains
yarikoptic 1afdc40
Add "Microelectrode" specialization for Electrophysiology in the cont…
yarikoptic 6b39d64
Fix up for bad latin and adjust wording a bit
yarikoptic f08b163
Replace fancy unicode “ with simple " .
yarikoptic 73012b3
Use redirected to www.datalad.org and www.nwb.org website URLs and fe…
yarikoptic a46e439
BEP032: ephys -> microephys with {icephys, ecephys} modalities/suffix…
yarikoptic 05e9611
Clarify wording and do mention `microephys` as shorthand for Microele…
yarikoptic 7ddeb75
Adding markdown portion of the Bep032 (#1960)
Peyman-N 2b9e757
[ENH] Schema changes related to BEP032 (#1826)
ree-gupta 6b11f54
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 1abebea
Some fixes of formatting and URLs
yarikoptic 2a3757d
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 3f4e941
Adjusted some formatting and some wording at the beginning of the sec…
yarikoptic 0853f8a
Few fixes to the schema from review
yarikoptic 800ba58
Adopting the markdown line lengths for BEP032 (#2012)
Peyman-N 46c91b0
Fix tabulation in a .tsv + convert to use yaw, pitch, roll
yarikoptic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
ephys: | ||
suffixes: | ||
- ephys | ||
extensions: | ||
- .nwb | ||
# possible future: serialization in .zarr format to accompany .ome.zarr | ||
# - .nwb.zarr | ||
- .nix | ||
datatypes: | ||
- ephys | ||
entities: | ||
subject: required | ||
session: optional | ||
sample: optional | ||
task: optional | ||
run: optional | ||
split: optional | ||
yarikoptic marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NWB files that exceed 2GB are not "conventionally" split into multiple parts. I don't know if this is true for NIX but I doubt it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should look into https://bids-specification.readthedocs.io/en/stable/appendices/entities.html#split may be it would apply