-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up examples in src/schema/README.md to not use outdated schema paths #1698
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
May be another simpler example should be chosen?
for more information, see https://pre-commit.ci
…org + add it to RTD workflow
4f9509f
to
66edbab
Compare
I found where schema.org is produced -- in RTD, but there in env there is no
moreover -- RTD succeeds! so that would not be appropriate place. we need to do it in another CI |
e1e12f8
to
1c0edcd
Compare
I also developed a script to catch those no longer valid paths used. I think it is worth adding it on CI
decide if we should not choose simpler example or may be make it fuller (give example of secondary dereference)