Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Hierarchical Event Descriptors (HED) page update #1623

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Sep 29, 2023

Squashed #1592 without some merge noise that reverted unrelated changes.

@tpatpa @VisLab Can you please review to make sure I didn't lose any of the originally planned changes?

Closes #1592.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f9cfafa) 87.83% compared to head (518d88d) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`events.tsv` file with onset `1.2` (the first row) is:

```Text
Duration/0.6 s, Sensory-event, Visual-presentation, (Square, Blue),
(Delay/1.435 ms, Agent-action, (Experiment-participant, (Press, Mouse-button))),
(Duration/0.6 s, Sensory-event, Visual-presentation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct without the curly brace notation, which is not yet supported by the HED javascript validator used in bids. Until that all goes through, the annotation for the presentation cannot be enclosed in parentheses:

Duration/0.6 s, Sensory-event, Visual-presentation, 
((Square, Red), (Computer-screen, Center-of)),

@effigies can you correct. Tal will not be available for a while.


### Using HED library schemas

HED also allows you to use one or more specialized vocabularies along with or instead of
HED also allows you to use one or more specialized vocabulary along with or instead of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be vocabularies not vocabulary because of the "more".

@@ -206,22 +224,24 @@ SCORE library for clinical neurological annotation located at
"HEDVersion": ["8.1.0", "sc:score_1.0.0"]
}
```
The `sc:` is a user-chosen prefixes used to distinguish the sources
The `sc:` is a user-chosen prefix used to distinguish the sources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sc: is a user-chosen prefix used to distinguish the source schemas

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested a few minor corrections. Thx!

@effigies
Copy link
Collaborator Author

effigies commented Oct 2, 2023

@VisLab Updated with your suggestions (or minor variations thereon). Please LMK what you think.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effigies effigies merged commit 6826c69 into master Oct 2, 2023
18 checks passed
@effigies effigies deleted the fix/hed branch October 2, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants