Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Do not require notch frequencies to be parsed as numbers, accommodating multiples #1605

Merged
merged 4 commits into from
Sep 21, 2023
Merged

[FIX] Do not require notch frequencies to be parsed as numbers, accommodating multiples #1605

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
861fb1f
FIX: Notch frequencies may be specified by three numbers
effigies Aug 31, 2023
3346056
SCHEMA: Drop from SHOULD to MAY to avoid validation implications
effigies Sep 8, 2023
296cebc
FIX: Multiple values are multiple notch frequencies
effigies Sep 8, 2023
4035e76
Merge branch 'master' into schema/notch-type
rwblair Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/schema/objects/columns.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,13 +302,11 @@ notch:
display_name: Notch frequencies
description: |
Frequencies used for the notch filter applied to the channel, in Hz.
If no notch filter applied, use `n/a`.
anyOf:
- type: number
unit: Hz
- type: string
enum:
- n/a
If notch filters are applied at multiple frequencies,
these frequencies MAY be specified as a list,
for example, `[60, 120, 180]`.
If no notch filter was applied, use `n/a`.
type: string
effigies marked this conversation as resolved.
Show resolved Hide resolved
onset:
name: onset
display_name: Event onset
Expand Down