Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update contribution workflow #1562
[DOC] Update contribution workflow #1562
Changes from 3 commits
2ec34f4
57cfc7c
9d4559b
e73e0bc
c234518
fe22532
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere else in the docs it say one can run the scripts with an empty
new_contributors.tsv
file to update everything (I guess avatar links etc.).It confuses me that the
new_contributors.tsv
file currently contains dummy data: As a maintainer executing the updating steps: can I remove the dummy data? Should I add it back later?Shouldn't such dummy data better be located under for example
tools/tests/data/dummy_new_contributors.tsv
?(Apart from this, I am still lacking a workflow to go from the wiki format to the TSV format)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that would be preferable indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently this is done "by hand" by whoever needs to update the contributors page