-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Propose to use *_channels.json
for the description of coordinate systems
#1524
Closed
Closed
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7417741
[FIX] move coordsys info to `channels.json`
JuliusWelzel 94bcab6
Merge branch 'bids-standard:master' into master
JuliusWelzel 40875ea
[FIX] naming of field in `channels.json`
JuliusWelzel 8fa6e20
Merge branch 'bids-standard:master' into master
JuliusWelzel dcb450a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 86e3498
Merge branch 'master' into master
sappelhoff 3ff382d
Merge branch 'bids-standard:master' into master
JuliusWelzel 4b07b4b
fix linebreak
JuliusWelzel 179c424
introduce `reference_frame` in channels chapter
JuliusWelzel c00d1c1
fix typo
JuliusWelzel 964705a
Merge branch 'bids-standard:master' into master
JuliusWelzel 98112eb
[FIX] `ReferenceFrameDescription` to `Description`
JuliusWelzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have a short TSV example with "reference_frame" "local" somewhere. Either a new one here or in the existing example above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did one example for now. In my experience that is less complicated, than providing multiple ones. It is mentioned in the text, that the
reference_frame
column is only RECOMMENDED.