-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] use schema to mention which "top directories" are allowed #1289
Conversation
Codecov ReportBase: 88.33% // Head: 88.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
+ Coverage 88.33% 88.39% +0.06%
==========================================
Files 11 11
Lines 1080 1086 +6
==========================================
+ Hits 954 960 +6
Misses 126 126
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is that what you had in mind? |
Another would be useful would be to add internal links to the sections of specs that relate to each directory. |
Perfect!
…On Fri, Sep 16, 2022 at 3:58 PM Remi Gau ***@***.***> wrote:
@VisLab <https://github.com/VisLab>
Is that what you had in mind?
https://bids-specification--1289.org.readthedocs.build/en/1289/02-common-principles.html#other-top-level-directories
—
Reply to this email directly, view it on GitHub
<#1289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJOVIYKD7HA5QMKO6HLDV6TNN3ANCNFSM6AAAAAAQOU5LYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Done |
@Remi-Gau Is this high priority, as in you want to get it in for the release? Trying to decide when to review this. |
not high priority IMHO |
No it's not a high priority, but I think it should go in at some point.
Thanks...
…On Tue, Sep 20, 2022 at 8:55 AM Remi Gau ***@***.***> wrote:
not high priority IMHO
@VisLab <https://github.com/VisLab> do you agree?
—
Reply to this email directly, view it on GitHub
<#1289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCJORLYYH6AH75YIPC7PTV7G66VANCNFSM6AAAAAAQOU5LYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to ultimately have all of the info about each folder in the schema, so we don't need to link out to specific sections, but I think linking is fine for now. I just have one small suggestion.
EDIT: Actually... maybe it would look better as a table?
converting to draft then -- please link to that "PR in the pipeline" if you know where it exists :) |
done |
Still need to add test but other than that we are back on track. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge, pending the test.
Should we do a separate PR for this? |
yes, I can do it, do you agree to always use the hyphen? |
Co-authored-by: Stefan Appelhoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly aesthetic comments.
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@Remi-Gau Thanks for seeing this through. |
closes #1284