more tweaks [ci skip]

bids-standard · Dec 18, 2024 · f64aa6e · f64aa6e
1 parent 62b9336
commit f64aa6e
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 8 deletions.
diff --git a/src/modality-specific-files/electromyography.md b/src/modality-specific-files/electromyography.md
@@ -176,8 +176,8 @@ A guide for using macros can be found at
   "EMGPlacement":"midpoint between cubital fossa and radial styloid process",
   "EMGReference":"TODO",
   "HardwareFilters":{"Highpass RC filter": {"Half amplitude cutoff (Hz)": 0.0159, "Roll-off": "6dBOctave"}},
-  "InstitutionAddress":"300 Pasteur Dr, Stanford, CA 94305",
-  "InstitutionName":"Stanford Hospital and Clinics",
+  "InstitutionAddress":"9500 Gilman Drive 0559, La Jolla, CA 92093",
+  "InstitutionName":"Swartz Center for Computational Neuroscience",
   "Instructions":"Jump straight upward as high as you can, while keeping your arms at your sides.",
   "Manufacturer":"Delsys",
   "ManufacturersModelName":"Trigno® Galileo",

diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml
@@ -954,7 +954,7 @@ EMGGround:
   display_name: EMG Ground
   description: |
     Description of the location of the ground electrode
-    (for example, `"placed on right styloid process"`).
+    (for example, `"right radial styloid process"`).
   type: string
 EMGPlacement:
   name: EMGPlacement

diff --git a/src/schema/objects/modalities.yaml b/src/schema/objects/modalities.yaml
@@ -8,6 +8,9 @@ eeg:
   display_name: Electroencephalography
   description: |
     Data acquired with EEG.
+# TODO do we need to add separate modalities for sEMG, hdsEMG, iEMG? I think not:
+#      "hd" is probably not relevant to specify (users can infer it from electrodes.tsv /
+#      channels.tsv) and surface vs intramuscular can be captured by ElectrodeType.
 emg:
   display_name: Electromyography
   description: |

diff --git a/src/schema/rules/sidecars/emg.yaml b/src/schema/rules/sidecars/emg.yaml
@@ -14,6 +14,10 @@ EMGHardware:
     ManufacturersModelName: recommended
     SoftwareVersions: recommended
     DeviceSerialNumber: recommended
+# TODO?
+#   AmplifierType: recommended
+#   ElectrodeManufacturer: recommended
+#   ElectrodeManufacturersModelName: recommended
 
 EMGTaskInformation:
   selectors:
@@ -63,17 +67,23 @@ EMGRecommended:
     - datatype == "emg"
     - suffix == "emg"
   fields:
-    TargetMuscle: recommended
+    ElectrodeMaterial: recommended
+    ElectrodeType: recommended
     EMGChannelCount: recommended
-    TriggerChannelCount: recommended
-    RecordingDuration: recommended
-    RecordingType: recommended
-    EpochLength: recommended
     EMGGround: recommended
+    EpochLength: recommended
     HardwareFilters: recommended
+    RecordingDuration: recommended
+    RecordingType: recommended
     SubjectArtefactDescription: recommended
+    TargetMuscle: recommended
+    TriggerChannelCount: recommended
 
 # Specific EMG fields MAY be present
+# TODO: InterElectrodeDistance: in channels.tsv probably, only for bipolar channels
+#       ElectrodeGroup: not sure this is still needed given our use of `acq`
+#       ElectrodeOrientation: incorporate into EMGPlacement?
+#       SkinPreparation: abrasive gel, alcohol wipe, etc.
 EMGOptional:
   selectors:
     - datatype == "emg"