-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enh: generalization of atlas metadata cc/ @jdkent
- Loading branch information
Showing
1 changed file
with
65 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f159e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oesteban! Just a quick question: would the transforms be derived in a different pipeline and indicated under
"sources"
in thejson
files?f159e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point -- I will address transforms ASAP. I agree it is a key aspect of this BEP, and should be reflected somewhere.
f159e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transforms between
templates
could be part oftemplateflow
, right (I think there are already some)? There's also neuromaps, which has quite a few transforms ready to go. However, I'm not sure how this would then be linked to a given pipeline... For thetemplate
tosubject
space
transforms: this could either re-use transforms computed during prior processing steps, e.g.fmriprep
, or computed within the pipeline at hand. Sorry if I missed something obvious or if this is not aligned with your proposal. Thanks again for working on this!f159e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we should encourage/signal the importance of providing subject-to-standard transforms for the subjects that were used in the atlas/template creation.
In other words, if we had a BIDS-derivatives dataset from MNI templates which preserved all the transformations of each subject to each of their different templates, it would be crazy awesome (e.g., to then build template-to-template transforms).
TemplateFlow is definitely interested in template-to-template transforms, but a BIDS derivatives dataset from which drawing them should have also the subject-to-template transforms in it.
Let me work this a bit further and I hope that will give you a full (and specific) answer - wdyt?
f159e61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on all things you mentioned. Please let me know if I can be of any help!