Skip to content

Commit

Permalink
[FIX] Demote sample and �alue columns in events.tsv from OPTIONAL to …
Browse files Browse the repository at this point in the history
…arbitrary (#1457)
  • Loading branch information
sappelhoff authored Apr 11, 2023
1 parent ed27faa commit e884bbf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
19 changes: 0 additions & 19 deletions src/schema/objects/columns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -396,16 +396,6 @@ response_time:
- type: string
enum:
- n/a
sample:
name: sample
display_name: Sample index
description: |
Onset of the event according to the sampling scheme of the recorded modality
(that is, referring to the raw data file that the `events.tsv` file accompanies).
When there are several sampling schemes present in the raw data file (as can be
the case for example for `.edf` files), this column is ambiguous and
SHOULD NOT be used.
type: integer
sample_id:
name: sample_id
display_name: Sample ID
Expand Down Expand Up @@ -818,15 +808,6 @@ units__motion:
and [Common Principles](SPEC_ROOT/common-principles.md#units) pages.
type: string
format: unit
value:
name: value
display_name: Marker value
description: |
Marker value associated with the event (for example, the value of a TTL
trigger that was recorded at the onset of the event).
anyOf:
- type: number
- type: string
volume_type:
name: volume_type
display_name: ASL volume type
Expand Down
2 changes: 0 additions & 2 deletions src/schema/rules/tabular_data/task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ TaskEvents:
columns:
onset: required
duration: required
sample: optional
trial_type: optional
response_time: optional
value: optional
HED: optional
stim_file: optional
additional_columns: allowed
Expand Down

0 comments on commit e884bbf

Please sign in to comment.