[FIX] motion channel types: remove ANGVEL, rename ANGACC -> ANGACCEL (#…

…1478) * [FIX] remove ANGVEL channel in motion channel types * remove motion angvel ch type from schema * ANGACC --> ANGACCEL --------- Co-authored-by: Stefan Appelhoff <[email protected]>
bids-standard · May 2, 2023 · e50373d · e50373d
1 parent 3d00184
commit e50373d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/src/modality-specific-files/motion.md b/src/modality-specific-files/motion.md
@@ -172,8 +172,7 @@ Note that upper-case is REQUIRED:
 | **Keyword** | **Description**                                                                                                                                                                                                                         |
 | ----------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | ACCEL       | Accelerometer channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z).                                                                                          |
-| ANGACC      | Angular acceleration channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z).                                                                                   |
-| ANGVEL      | Angular velocity channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z).                                                                                       |
+| ANGACCEL    | Angular acceleration channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z).                                                                                   |
 | GYRO        | Gyrometer channel, one channel for each spatial axis. Column component for the axis MUST be added to the *_channels.tsv file (x, y, or z).                                                                                              |
 | JNTANG      | Joint angle channel between two fixed axis belonging to two bodyparts. Angle SHOULD be defined between proximal and distal bodypart in deg.                                                                                             |
 | LATENCY     | Latency of samples in seconds from recording onset (see `acq_time` column of the respective `*_scans.tsv` file). MUST be in form of `s[.000000]`, where `s` reflects whole seconds, and `.000000` reflects OPTIONAL fractional seconds. |

diff --git a/src/schema/objects/columns.yaml b/src/schema/objects/columns.yaml
@@ -747,8 +747,7 @@ type__motion_channels:
   type: string
   enum:
     - ACCEL
-    - ANGACC
-    - ANGVEL
+    - ANGACCEL
     - GYRO
     - JNTANG
     - LATENCY

diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml
@@ -140,8 +140,8 @@ AnatomicalLandmarkCoordinates__mri:
       type: number
     minItems: 3
     maxItems: 3
-ANGACCChannelCount:
-  name: ANGACCChannelCount
+ANGACCELChannelCount:
+  name: ANGACCELChannelCount
   display_name: Angular acceleration channel count
   description: |
     Number of angular acceleration channels.

diff --git a/src/schema/rules/sidecars/motion.yaml b/src/schema/rules/sidecars/motion.yaml
@@ -61,7 +61,7 @@ motionRecommended:
     - suffix == "motion"
   fields:
     ACCELChannelCount: recommended
-    ANGACCChannelCount: recommended
+    ANGACCELChannelCount: recommended
     GYROChannelCount: recommended
     JNTANGChannelCount: recommended
     LATENCYChannelCount: recommended
-Original file line number
+Diff line change
@@ Expand Up / @@ -747,8 +747,7 @@ type__motion_channels: @@
       type: string
       enum:
         - ACCEL
-        - ANGACC
-        - ANGVEL
+        - ANGACCEL
         - GYRO
         - JNTANG
         - LATENCY
@@ Expand Down @@