-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SCHEMA] Add TSV column files (#827)
* Add template. * Add first column. * Add columns. * More terms. * Fill name field in all files. * More work. Note that there are three very different uses of "name" columns, and two of them are equally common, so I chose not to specify any of them as the "canonical" definition. * Add remaining definitions. * Add macro to render column tables. * Fix YAML file. * Consolidate suffixes file. * Remove old individual files. * Move columns file. * Fix things up a bit. * Add columns I missed for modality-agnostic TSV files. * Support n/a for duration. * Apply suggestions from code review Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Stefan Appelhoff <[email protected]> * Code formatting in stim_file definition. * Allow numbers and strings for value. * Update src/schema/objects/columns.yaml Co-authored-by: Stefan Appelhoff <[email protected]> * Allow n/a for "z" column. Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723280787. * Describe meanings of x, y, and z columns. Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723283314. * Allow n/a for status column. Addresses https://github.com/bids-standard/bids-specification/pull/827/files#r723269382. * Add participant_id to participants.tsv table and append info for other IDs. * Split type definitions into channels and electrodes versions. * Update definitions for group based on file type. * Split reference column definition. * Clean up name_channels definition. * Draft new columns from #816 * Add new columns to table. * Remove list items. * Update src/04-modality-specific-files/04-intracranial-electroencephalography.md Co-authored-by: Stefan Appelhoff <[email protected]> * Apply suggestions from code review Co-authored-by: Chris Markiewicz <[email protected]> * Use two underscores to delineate multiply-defined columns. * Remove text that is now in table. * Update src/schema/objects/columns.yaml Co-authored-by: Chris Markiewicz <[email protected]> * Add sections to README on columns file and on reused terms. * Add EDF info to acq_time definition. * Remove hardcoded tables. * Remove unused links. Co-authored-by: Chris Markiewicz <[email protected]> Co-authored-by: Stefan Appelhoff <[email protected]>
- Loading branch information
1 parent
18e2057
commit 5400d6f
Showing
13 changed files
with
898 additions
and
191 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.