Skip to content

Commit

Permalink
Apply additional suggestions from code review
Browse files Browse the repository at this point in the history
    Co-authored-by: Chris Markiewicz <[email protected]>
  • Loading branch information
CGSchwarzMayo committed Apr 24, 2024
1 parent 85c9e80 commit 2c01417
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 60 deletions.
51 changes: 25 additions & 26 deletions src/modality-specific-files/magnetic-resonance-imaging-data.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,31 @@ A guide for using macros can be found at
-->
{{ MACROS___make_sidecar_table("mri.MRISample") }}

## Deidentification information

Describes the mechanism or method used to modify or remove metadata
and/or pixel data to protect the patient or participant's identity.

<!-- This block generates a metadata table.
These tables are defined in
src/schema/rules/sidecars
The definitions of the fields specified in these tables may be found in
src/schema/objects/metadata.yaml
A guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_sidecar_table("mri.DeidentificationMethod") }}

Each object in the `DeidentificationMethodCodeSequence` array includes the following RECOMMENDED keys:

<!-- This block generates a table describing subfields within a metadata field.
The definitions of these fields can be found in
src/schema/objects/metadata.yaml
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_subobject_table("metadata.DeidentificationMethodCodeSequence.items") }}

## Anatomy imaging data

Anatomy MRI sequences measure static, structural features of the brain.
Expand Down Expand Up @@ -356,32 +381,6 @@ recommended metadata fields, and the application specific entity or
metadata requirement levels of [file collections](../appendices/file-collections.md) that can generate
them, visit the [qMRI appendix](../appendices/qmri.md).

### Deidentification information

Describes the mechanism or method used to modify or remove metadata
and/or pixel data to protect the patient or participant's identity.

<!-- This block generates a metadata table.
These tables are defined in
src/schema/rules/sidecars
The definitions of the fields specified in these tables may be found in
src/schema/objects/metadata.yaml
A guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_sidecar_table("mri.DeidentificationMethod") }}

Each object in the `DeidentificationMethodCodeSequence` array includes the following RECOMMENDED keys:

<!-- This block generates a table describing subfields within a metadata field.
The definitions of these fields can be found in
src/schema/objects/metadata.yaml
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_subobject_table("metadata.DeidentificationMethodCodeSequence.items") }}


### Defacing masks

If the structural images included in the dataset were defaced (to protect
Expand Down
24 changes: 1 addition & 23 deletions src/modality-specific-files/positron-emission-tomography.md
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ time plasma_radioactivity whole_blood_radioactivity metabolite_parent_fraction m
7193 19.71 15.70 0.02 0.559
```

### Deidentification information
## Deidentification information

Describes the mechanism or method used to modify or remove metadata
and/or pixel data to protect the patient or participant's identity.
Expand All @@ -459,25 +459,3 @@ and a guide for using macros can be found at
-->
{{ MACROS___make_subobject_table("metadata.DeidentificationMethodCodeSequence.items") }}


### Defacing masks

If the structural images included in the dataset were defaced (to protect
identity of participants) one MAY provide the binary mask that was used to
remove facial features in the form of `_defacemask` files.
In such cases, the OPTIONAL [`mod-<label>`](../appendices/entities.md#mod)
entity corresponds to modality suffix,
such as `T1w` or `inplaneT1`, referenced by the defacemask image.
For example, `sub-01_mod-T1w_defacemask.nii.gz`.

<!--
This block generates a filename templates.
The inputs for this macro can be found in the directory
src/schema/rules/files/raw
and a guide for using macros can be found at
https://github.com/bids-standard/bids-specification/blob/master/macros_doc.md
-->
{{ MACROS___make_filename_template("raw", datatypes=["anat"], suffixes=[
"defacemask",
])
}}
11 changes: 0 additions & 11 deletions src/schema/rules/sidecars/pet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -276,14 +276,3 @@ PETTask:
TaskDescription: recommended
CogAtlasID: recommended
CogPOID: recommended

DeidentificationMethod:
selectors:
- intersects([modality], ["mri", "pet"])
fields:
DeidentificationMethod:
level: optional
description_addendum: Corresponds to DICOM Tag 0012, 0063 `De-identification Method`.
DeidentificationMethodCodeSequence:
level: optional
description_addendum: Corresponds to DICOM Tag 0012, 0064 `De-identification Method Code Sequence`.

0 comments on commit 2c01417

Please sign in to comment.