-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Split out tractography #9
Conversation
This PR splits the tractography section from the diffusion derivatives document, so that #5 is easier to merge. The new ``05-diffusion-derivatives-tractography.md`` file will remain orphaned, but kept there as a base for the time we tackle tractography. It shouldn't be merged into the derivatives branch until it is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
## Describing tractography | ||
|
||
Tractography normally generates one of two primary file types: tractograms or | ||
NIfTi files containing maps. Tractograms are files containing a collection of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really how nifti is capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say more about the file formats used to store tractograms?
<pipeline_name>/ | ||
sub-<participant_label>/ | ||
dwi/ | ||
<source_keywords>[_space-<space>][_desc-<label>][_subset-<label>]_tractography.[trk|tck|nii[.gz]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - there they are!
|
||
`subset` (optional) – A label descriptor for the the subset of streamlines | ||
included in this file; if not specified, a whole brain tractography is assumed | ||
(a tractogram). Example of subsets can be `short` if only short streamlines were |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a tractogram). Example of subsets can be `short` if only short streamlines were | |
(a full connectome). Example of subsets can be `short` if only short streamlines were |
Hey @francopestilli - is that the right terminology? "Tracogtram" refers to any subset, and "whole brain" is called "connectme" ?
| LOCAL | NULL | Morris et al. (2008) | | ||
| GLOBAL | UKF | Malcolm J-G. et al. (2009) | | ||
| GLOBAL | SpinGlass | Fillard P. et al. (2009) | | ||
| GLOBAL | ENS | Takemura et al. (2016) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ENS really belong under the "global" category? Arguably, it can't generate anything that's not in one of the local tractograms in the ensemble?
| **Key name** | **Description** | | ||
| ------------------ | -------------------------------------------------------------------------------------------------------------------- | | ||
| TractographyClass | REQUIRED. Allowed values: `local`, `global` | | ||
| TractographyMethod | REQUIRED. Allowed values: `probabilistic`,`deterministic`,`eudx`,`fact`,`stt`,`null`,`ukf`,`spinglass`,`ens`,`other` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add "pft" (particle filtering tractography, see Girard et al., 2014)
| ------------------ | -------------------------------------------------------------------------------------------------------------------- | | ||
| TractographyClass | REQUIRED. Allowed values: `local`, `global` | | ||
| TractographyMethod | REQUIRED. Allowed values: `probabilistic`,`deterministic`,`eudx`,`fact`,`stt`,`null`,`ukf`,`spinglass`,`ens`,`other` | | ||
| Count | REQUIRED. integer | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the number of streamlines stored in the file?
Do you want this merged ASAP, and come back to these comments later? |
Yup, could you open a PR with your comments after this is merged? |
Oh - no big green button! Looks like I don't have the permissions to merge this. :trombone: |
Fixed that! |
This PR splits the tractography section from the diffusion derivatives
document, so that #5 is easier to merge.
The new
05-diffusion-derivatives-tractography.md
file will remainorphaned, but kept there as a base for the time we tackle tractography.
It shouldn't be merged into the derivatives branch until it is ready.