-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes behav in singl-session-subjects in long study #24
Conversation
The run.py code change looks like it would reset |
Thanks. I reverted to my very first implementation that searches for the first multi-sessions subject and stops if it is found. I've also added a |
That looks right... you could also just set longitudinal_study to False
above the loop, then break when set to True on line 100, without an
additional variable and drop the else conditional on line 105
…----------------------------------------------------------------
Alexander Li Cohen, M.D., Ph.D.
E-mail: [email protected] (Medical/Science Email)
E-mail: [email protected] (Lifetime Email)
----------------------------------------------------------------
On Tue, Jan 31, 2017 at 12:40 PM, Franz Liem ***@***.***> wrote:
Thanks. I reverted to my very first implementation that searches for the
first multi-sessions subject and stops if it is found. I've also added a
multi_session_study variable to make things clearer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIPa_7-LfNS4OaaZAoDQJCwwoiU5ow3Bks5rX3IAgaJpZM4LyWXr>
.
|
My thinking was that it might not hurt to have this variable for later.
… Am 31.01.2017 um 18:45 schrieb Alexander Li Cohen ***@***.***>:
That looks right... you could also just set longitudinal_study to False
above the loop, then break when set to True on line 100, without an
additional variable and drop the else conditional on line 105
----------------------------------------------------------------
Alexander Li Cohen, M.D., Ph.D.
E-mail: ***@***.*** (Medical/Science Email)
E-mail: ***@***.*** (Lifetime Email)
----------------------------------------------------------------
On Tue, Jan 31, 2017 at 12:40 PM, Franz Liem ***@***.***>
wrote:
> Thanks. I reverted to my very first implementation that searches for the
> first multi-sessions subject and stops if it is found. I've also added a
> multi_session_study variable to make things clearer.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AIPa_7-LfNS4OaaZAoDQJCwwoiU5ow3Bks5rX3IAgaJpZM4LyWXr>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFgWC6w2BD0HHby1guQBrXdZwQAyy4Ofks5rX3McgaJpZM4LyWXr>.
|
This is the revived PR #22.
In longitudinal studies (studies in which at least one subject has more than one session) and --multiple_sessions='longitudinal') subjects with only one session should undergo the entire longitudinal stream. The changes in #11 broke that behavior. The present changes should fix it.
recon-all
commands in a second loop.