PDF Generator update #361

DanielC-N · 2024-09-09T22:22:57Z

added a button on the top right corner to generate a PDF from one or more project with different downloaded resources.

- added a 'factoryCreateContent.js' file to help factorize some code for 'createObsContent', 'createVersificationUSFM' and 'createAudioVersification' in 'saveProjetcsMeta.js' - fixing some typos, fixing lint

… to search and download a SB as a resource in a module

- auto load a book on the opening of a project - auto save after a modification - fixed a bit of typos and code

…lso edited the icon for Juxta mode (it's visible now) you can create a new juxta project

…nge the way a juxta json is built.

…te it if needed. and layout color update

…pture-editor into dcn/refactor_modes

…, 'double click' to modify a chunck, 'enter' to end the modification of a chunck. And added seemless navigation between Juxtalinear editor and the BibleEditorX. Navigating through verses and chapters with the menu bar will load the corresponding sentence and vice versa.

… skip for the liter for .ts files

… the user : to know if the help pop has already been opened once

…hnology#357

DanielC-N · 2024-09-10T12:19:42Z

actions/upload-artifact@v1 is now deprecated and unusable.
Today I received an error from github actions : "Error: This request has been automatically failed because it uses a deprecated version of **actions/upload-artifact: v1**. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/"

[1/4] Resolving packages... success Already up-to-date. Done in 0.65s. so I'm trying to make it verbose to detect the problem. Also, I authorized the overwrite of the artifacts

…cts to avoid error within github actions

selvabenz · 2024-09-11T04:40:22Z

@DanielC-N, the PR looks good. there are some suggestions I have.

If you could keep the Scribe UI standard, the whole UI would look consistent. @arpitjacob can help you with the UI standards
Reset parameters is inactive when I want to reset
Start page side, user may understand Right and Left easily than Recto and Verso. (just a suggestion)
In "Your file name here", unable to give any space and special character. if it is kept intentionally, ignore this
Add validation message for the "Choose export Folder" and "Your file name here" if "Choose export Folder" not chosen or "Your file name here" name typed
Add validation message for OBS start and end
If "Your file name here" is empty it is taking random alphabet and generates the PDF
On one instance I did not select "show page number but in the message area it shows "Generate Page Numbers"
Add complete or failed message when the printing is done or failed
Sample PDF of the Juxta, OBS and Text translation
Test.pdf
b.pdf
t.pdf

All the other functions are looking good.

DanielC-N · 2024-09-11T16:12:36Z

If you could keep the Scribe UI standard, the whole UI would look consistent. @arpitjacob can help you with the UI standards ❌
Reset parameters is inactive when I want to reset ✅
Start page side, user may understand Right and Left easily than Recto and Verso. (just a suggestion) ❌
In "Your file name here", unable to give any space and special character. if it is kept intentionally, ignore this => This is intentional but I added a notice ✅
Add validation message for the "Choose export Folder" and "Your file name here" if "Choose export Folder" not chosen or "Your file name here" name typed ✅
Add validation message for OBS start and end ❓
If "Your file name here" is empty it is taking random alphabet and generates the PDF => I put a string of random words ✅
On one instance I did not select "show page number but in the message area it shows "Generate Page Numbers" ✅
Add complete or failed message when the printing is done or failed ✅

selvabenz · 2024-09-12T04:14:40Z

Thanks, @DanielC-N for updating the PR.

I have made a video to explain point no 6 Add validation message for OBS start and end ❓
https://www.awesomescreenshot.com/video/31440031?key=012d2af149814967156640a5b86a9140

DanielC-N · 2024-09-12T10:10:52Z

@selvabenz I've hidden the print button on audio projects.
After the discussion for the OBS. Nothing was changed.

selvabenz · 2024-09-12T10:53:03Z

@vipinpaul, all the necessary corrections are made by @DanielC-N, we can go for a merge.

danielc-n and others added 30 commits January 16, 2024 15:20

- added a Juxta mode that creates a translation burrito

1d1626d

- added a 'factoryCreateContent.js' file to help factorize some code for 'createObsContent', 'createVersificationUSFM' and 'createAudioVersification' in 'saveProjetcsMeta.js' - fixing some typos, fixing lint

Refactorization of 'saveProjectsMeta.js'

620a9cb

merging changes for PR

d8c1202

Scripture Burrito as a resource : added the poissibility for the user…

f77dfd3

… to search and download a SB as a resource in a module

removed checkbox from the UI and query sb resource everytime

34d947a

Added a juxtalinear editor along with a new mode.

70b68c0

- auto load a book on the opening of a project - auto save after a modification - fixed a bit of typos and code

created a juxtaBurrito creator and a function to add juxta content. A…

234998d

…lso edited the icon for Juxta mode (it's visible now) you can create a new juxta project

ADDED juxta support for SB creation and fixed some typos

5c9eef4

merged with dev

15ba171

ADDED support for usfm import for a juxta project. Now we have to cha…

716d72b

…nge the way a juxta json is built.

juxtalineat mode functionnal

12aadc0

Merge branch 'development' into dcn/refactor_modes

f77d94b

UPDATE : now the interface handle corectly a json juxta file and upda…

034dca5

…te it if needed. and layout color update

function to update a json juxta file if needed

8d39efc

Merge branch 'dcn/refactor_modes' of github.com:Proskomma/scribe-scri…

3a20921

…pture-editor into dcn/refactor_modes

checksums ok for each modifications of the juxta

17ec0a9

bugfix : juxta was still using a translation settings

00bd137

quick fix

0dd7e17

Merge branch 'bible-technology:development' into development

a947db3

Merge branch 'development' into dcn/refactor_modes

4f13526

removing a useless 'console.log'

e906685

FIXED font size when aditing a chunck, ADDED a bit of css and added a…

97d0ada

… skip for the liter for .ts files

added juxtalinear alignment editor

e11baad

added prototype of Grammateus

8078c2d

added release for win64

1689913

to the point it works in scribe

efb2146

checkpoint for juxtaligner

92bf339

base code for pdf print

7dcef5b

UPDATE succesful. we also save ne more option to the settings file of…

378f72e

… the user : to know if the help pop has already been opened once

danielc-n and others added 16 commits August 28, 2024 10:53

updated deps and merged with print_pdf branch

3d11037

updated jxl and updated the code to work with juxta

3f0d807

add last changes for PDF print.

26635e8

removed juxtalign mode and bugfix : bible-technology#357 => bible-tec…

d03dc3a

…hnology#357

Merge branch 'bible-technology:development' into development

c800791

intagrated dev branch update

62d677a

trying to increase ulimit

d243114

installing distutils setuptools directly from brew for mac machine

a30673d

installing python-setuptools

ccc2696

dist : release error

341d8e4

trying a configuration to increase 'maxConcurrentTasks'

0114eed

removed @mui/icons-react from deps and let it in devDeps

476370d

updated jxl-pdf

edc7063

correction of code

6b0c81a

increased maxfiles form kernel directly

83eda81

updated actions/upload-artifact@v1 to v4

c20fbdd

danielc-n added 3 commits September 10, 2024 14:20

trying kern.maxfiles=10485760 with sudo

741d100

the mac build take too much time for yarn install v1.22.19

428414e

[1/4] Resolving packages... success Already up-to-date. Done in 0.65s. so I'm trying to make it verbose to detect the problem. Also, I authorized the overwrite of the artifacts

removed some useless 'console.log' and changed the name of the artifa…

9e5f8ee

…cts to avoid error within github actions

danielc-n added 3 commits September 11, 2024 14:21

updated jxl-pdf

8e824f2

working reset button

760fa75

changes for : bible-technology#361 (comment)

3a51358

hide the print button on audio projects

b645b67

vipinpaul merged commit 7745fd3 into bible-technology:development Sep 12, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PDF Generator update #361

PDF Generator update #361

DanielC-N commented Sep 9, 2024

DanielC-N commented Sep 10, 2024

selvabenz commented Sep 11, 2024 •

edited

Loading

DanielC-N commented Sep 11, 2024 •

edited

Loading

selvabenz commented Sep 12, 2024

DanielC-N commented Sep 12, 2024

selvabenz commented Sep 12, 2024

PDF Generator update #361

PDF Generator update #361

Conversation

DanielC-N commented Sep 9, 2024

DanielC-N commented Sep 10, 2024

selvabenz commented Sep 11, 2024 • edited Loading

DanielC-N commented Sep 11, 2024 • edited Loading

selvabenz commented Sep 12, 2024

DanielC-N commented Sep 12, 2024

selvabenz commented Sep 12, 2024

selvabenz commented Sep 11, 2024 •

edited

Loading

DanielC-N commented Sep 11, 2024 •

edited

Loading