Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modification of Logic #319

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Modification of Logic #319

merged 6 commits into from
Apr 15, 2024

Conversation

sijumoncy
Copy link
Collaborator

@selvabenz
Copy link

All the changes are reflected and the functions that are related to these changes are working as expected. This PR can be merged.

image

@selvabenz
Copy link

selvabenz commented Apr 10, 2024 •
edited
Loading

@sijumoncy and @vipinpaul there is a correction in the requirement. Birch says, "I think it should default to aligned. And then have options for aligned, unaligned, and both". Please make the changes as mentioned.

@selvabenz
Copy link

selvabenz commented Apr 10, 2024 •
edited
Loading

@sijumoncy please remove the type
auto selection.

image

@selvabenz
Copy link

selvabenz commented Apr 10, 2024 •
edited
Loading

@vipinpaul all the necessary changes have been made and reflected as expected. Therefore please merge this PR.

image

@vipinpaul vipinpaul merged commit 4a87b1d into development Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipinpaul vipinpaul vipinpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Save Filter' button should just say 'Filter' The default Bible resources page should show aligned Bibles
3 participants
@sijumoncy @selvabenz @vipinpaul