Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripture Burrito as a resource #309

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

DanielC-N
Copy link
Contributor

added the possibility for the user to search and download a SB as a resource in a module.

… to search and download a SB as a resource in a module
@DanielC-N
Copy link
Contributor Author

Screenshot from 2024-02-02 13-23-42

Now you have a checkbox "get scripture burrito"

@selvabenz
Copy link

selvabenz commented Feb 5, 2024

Hi @DanielC-N This PR is working fine as expected.
I discussed with the BCS dev team they are suggesting "on search, to bring the RC and SB together" that would cause less confusion to the users. Could you remove the check box from the UI? "Add the SB along with the existing list. This will avoid a click and the users may not be aware of the RC and SB".

@selvabenz
Copy link

Thank you @DanielC-N for the changes! This PR is working as expected.

  • SB content has been added to the existing RC list in the resource pane, without a checkbox
    @vipinpaul this PR can be merged.

image

image

@vipinpaul vipinpaul merged commit a301189 into bible-technology:development Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants