Texteditor refactor #190
Merged
Texteditor refactor #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueljd
force-pushed
the
refactor/editor
branch
4 times, most recently
from
86c36e2 to
89195ab
Compare
|
@samueljd, Please check this video. All the issues faced explained here: https://www.awesomescreenshot.com/video/22444558?key=acbe9359cf8fb464bfb8ff5cdea8e809 |
samueljd
force-pushed
the
refactor/editor
branch
3 times, most recently
from
bd65038 to
e9f440e
Compare
samueljd
force-pushed
the
refactor/editor
branch
from
e9f440e to
8f4dc8a
Compare
|
@vipinpaul, all the functions are working as before the refactor. This PR can be merged. Along with the text editor refactor some additional fixes that took place in this PR
|
vipinpaul
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed insert verse,chapter, footnote, xref issue.
Fixes #28
Fixes #29