feat: add a notification when connected to kernel #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting to try out this plugin and seems great so far. I got inspiration from this blogpost:
https://www.blog.gambitaccepted.com/2020/04/26/neovim-qtconsole-setup/
and am planning to similarly use nvim-ipy with
--no-window. But in this case it would be nice to get a notification that the connection to the kernel occurs. This PR adds such a simple call, let me know if it seems okay.(btw, I tried to call
vim.notifydirectly but the python object did not have this attribute)