This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Bugfix/chef rhn 12 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request bflad#11 from zachsmorgan/master
bflad
suggested changes
Dec 18, 2016
There was a problem hiding this comment.
Could you please do the following?
- Rename
execute_cmd_maybe?toexecute_cmd_with_retries--?ending methods in Ruby generally return TrueClass/FalseClass. - Call
execute_cmdinstead ofshell_out!inside the new retrying method - we shouldn't need to update the shell out logic in two places - Potentially make the number of tries a resource attribute (e.g.
cmd_tries) that defaults to 5
Thanks!
|
@bflad I managed to completely miss your comments somehow... I was hacking around at adding some more verbose output during the reg process and just happened to see this PR was still open. Can you check the commits I just added and confirm this makes the cut now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #12