refactor FileHelper.cs file

bezzad · Sep 18, 2024 · 51b9239 · 51b9239
1 parent de6461f
commit 51b9239
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/src/Downloader/Extensions/Helpers/FileHelper.cs b/src/Downloader/Extensions/Helpers/FileHelper.cs
@@ -18,12 +18,10 @@ public static Stream CreateFile(string filename)
             Directory.CreateDirectory(directory);
         }
 
-        return new FileStream(filename, FileMode.OpenOrCreate, FileAccess.Write, FileShare.ReadWrite | FileShare.Delete);
-    }
-    public static string GetTempFile()
-    {
-        return GetTempFile(Path.GetTempPath(), string.Empty);
+        return new FileStream(filename, FileMode.OpenOrCreate, FileAccess.Write,
+            FileShare.ReadWrite | FileShare.Delete);
     }
+
     public static string GetTempFile(string baseDirectory, string fileExtension)
     {
         if (string.IsNullOrWhiteSpace(baseDirectory))
@@ -41,13 +39,8 @@ public static long GetAvailableFreeSpaceOnDisk(string directory)
     {
         try
         {
-            var drive = new DriveInfo(directory);
-            if (drive.IsReady)
-            {
-                return drive.AvailableFreeSpace;
-            }
-
-            return 0L;
+            DriveInfo drive = new(directory);
+            return drive.IsReady ? drive.AvailableFreeSpace : 0L;
         }
         catch (ArgumentException)
         {
@@ -58,15 +51,16 @@ public static long GetAvailableFreeSpaceOnDisk(string directory)
 
     public static void ThrowIfNotEnoughSpace(long actualNeededSize, params string[] directories)
     {
-        if (directories != null)
+        if (directories == null)
+            return;
+
+        foreach (string directory in directories)
         {
-            foreach (string directory in directories)
+            long availableFreeSpace = GetAvailableFreeSpaceOnDisk(directory);
+            if (availableFreeSpace > 0 && availableFreeSpace < actualNeededSize)
             {
-                var availableFreeSpace = GetAvailableFreeSpaceOnDisk(directory);
-                if (availableFreeSpace > 0 && availableFreeSpace < actualNeededSize)
-                {
-                    throw new IOException($"There is not enough space on the disk `{directory}` with {availableFreeSpace} bytes");
-                }
+                throw new IOException($"There is not enough space on the disk `{directory}` " +
+                                      $"with {availableFreeSpace} bytes");
             }
         }
     }