Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't preload glyphs for non-alphanumeric fonts. #1806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saurtron
Copy link
Collaborator

@saurtron saurtron commented Dec 9, 2024

Work done

  • Don't preload glyphs for non-alphanumeric fonts

Explanation

  • Forces loading lots of fallbacks in that case so not very useful
  • Have this in the colored-fonts branch, but doesn't really belong there.
  • Fits better into the fallback-fonts* branches (just because with that ppl will likely be using more non-alphanumeric fonts), but anyways I think this is stand alone so maybe we can review and merge this independently.

@saurtron saurtron added the fonts label Dec 9, 2024
@lhog
Copy link
Collaborator

lhog commented Dec 10, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants