Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the newly added modoptions #1802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sprunk
Copy link
Collaborator

@sprunk sprunk commented Dec 7, 2024

Let's not introduce a new sub-table, would require back-compat when modoptions are flattened after #1260.

@lhog
Copy link
Collaborator

lhog commented Dec 7, 2024

Well, idk about that one. Not totally sure #1260 is advantageous.
Perhaps let's do it in a soft way at least, i.e. expose the same existing option w/o the subtables as well and keep it that way for some time.

Before they get used. See #1260
@sprunk sprunk force-pushed the flatten-windchange-modopt branch from f0b1271 to 427d350 Compare December 7, 2024 18:43
@sprunk sprunk changed the title Flatten the new wind change modoption Flatten the newly added modoptions Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants