Fix performance issue where an early bad out isn't available for part…

…ially-shared incomplete paths.
beyond-all-reason · Dec 4, 2023 · 35a026a · 35a026a
1 parent 2cc591c
commit 35a026a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/rts/Sim/Path/QTPFS/PathSearch.cpp b/rts/Sim/Path/QTPFS/PathSearch.cpp
@@ -214,6 +214,7 @@ void QTPFS::PathSearch::LoadPartialPath(IPath* path) {
 			// explicitly doesn't capture the step index if it hits an early drop out.
 		});
 	}
+	expectIncompletePartialSearch = (badNodeCount > 0);
 }
 
 // #pragma GCC pop_options
@@ -454,6 +455,9 @@ bool QTPFS::PathSearch::ExecutePathSearch() {
 				searchThreadData->ResetQueue(SearchThreadData::SEARCH_FORWARD);
 				searchThreadData->ResetQueue(SearchThreadData::SEARCH_BACKWARD);
 			}
+			// We're done with the forward path and we expect the reverse path to fail so stop it right there.
+			if ((*fwd.openNodes).empty() && expectIncompletePartialSearch)
+				searchThreadData->ResetQueue(SearchThreadData::SEARCH_BACKWARD);
 		}
 
 		if (!(*bwd.openNodes).empty()) {

diff --git a/rts/Sim/Path/QTPFS/PathSearch.h b/rts/Sim/Path/QTPFS/PathSearch.h
@@ -224,6 +224,7 @@ namespace QTPFS {
 		bool doPartialSearch = false;
 		bool rejectPartialSearch = false;
 		bool allowPartialSearch = false;
+		bool expectIncompletePartialSearch = false;
 		bool searchEarlyDrop = false;
 		bool initialized = false;
 		bool partialReverseTrace = false;